fix: allow underscores in git PackageDownloadLocation validation#886
Open
fix: allow underscores in git PackageDownloadLocation validation#886
Conversation
The git_pattern regex rejected repository names containing underscores, such as CMSIS_6. This adds underscore to the allowed character class in the path segment of git+git@ download locations. Closes spdx#860 Signed-off-by: Rizky Mirzaviandy Priambodo <142987522+Xavrir@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
git+git@download locationsgit_patternregex inuri_validators.pywas missing_in its allowed character class, causing valid URLs likegit+git@github.com:zephyrproject-rtos/CMSIS_6@...to fail validationspdx-java-model-2_X#33)Testing
pytest -vvspasses all 69 URI validator testsisort,black,flake8all cleanCloses #860